]> dgit.raspbian.org Git - gnome-shell.git/commit
shell/app: Re-order running-state cleanup
authorFlorian Müllner <fmuellner@gnome.org>
Wed, 22 Dec 2021 00:53:17 +0000 (01:53 +0100)
committerFlorian Müllner <fmuellner@gnome.org>
Wed, 22 Dec 2021 00:55:05 +0000 (01:55 +0100)
commit331454a757bf48cd7eb597bf5e8d1f2d190708e5
tree8c010bd4f7a168cb24aaa719d01675ba99c2ba2a
parent7e0c6dc2c105b0a0b46bc1e4b32280f6ae9be959
shell/app: Re-order running-state cleanup

Since commit 1807be1, we clear the fallback icon when a window is
removed, and notify the icon change. The notify call currently
happens after removing the window from the running state, but
before syncing the state (and possibly clear the running state
altogether).

That state is inconsistent and results in an assertion hit when
some code tries to re-fetch the icon in response to the notify
call.

Address this by updating the state before clearing the fallback
icon, so that the app will be in the correct STOPPED state after
removing the last window.

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4888

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2073>
src/shell-app.c